feat(app, api-client, react-api-client): add api-client method for protocol reanalysis #14878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analysis
On the ODD, we need to trigger protocol reanalysis via a new `/protocols/{protocolId}/analyses`
endpoint post request. This analysis should occur when a user sends confirms values on an
RTP-containing protocol on the ODD.
…fault in ProtocolSetupParameters
koji
reviewed
Apr 11, 2024
app/src/atoms/InputField/index.tsx
Outdated
| @@ -75,6 +75,7 @@ export interface InputFieldProps { | |||
| | typeof TYPOGRAPHY.textAlignCenter | |||
| /** small or medium input field height, relevant only */ | |||
| size?: 'medium' | 'small' | |||
| ref?: React.MutableRefObject<null> | |||
There was a problem hiding this comment.
mistake from merging in edge. I will fix
koji
reviewed
Apr 11, 2024
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react' | |||
| import { KeyboardReact as Keyboard } from 'react-simple-keyboard' | |||
| import Keyboard from 'react-simple-keyboard' | |||
There was a problem hiding this comment.
Other keyboards use import { KeyboardReact as Keyboard } from 'react-simple-keyboard'
There was a problem hiding this comment.
same as above. reverting...
koji
reviewed
Apr 11, 2024
Comment on lines
100
to
104
| const { createProtocolAnalysis } = useCreateProtocolAnalysisMutation( | ||
| {}, | ||
| protocolId, | ||
| host | ||
| ) |
There was a problem hiding this comment.
If we change like below
export function useCreateProtocolAnalysisMutation(
protocolId: string | null,
hostOverride?: HostConfig | null,
options: UseCreateProtocolAnalysisMutationOptions | undefined = {}
): UseCreateProtocolMutationResult {We don't need to pass {}.
Suggested change
| const { createProtocolAnalysis } = useCreateProtocolAnalysisMutation( | |
| {}, | |
| protocolId, | |
| host | |
| ) | |
| const { createProtocolAnalysis } = useCreateProtocolAnalysisMutation( | |
| protocolId, | |
| host | |
| ) |
There was a problem hiding this comment.
smart. fixing that.
koji
reviewed
Apr 11, 2024
| HostConfig, | ||
| RunTimeParameterCreateData, | ||
| } from '@opentrons/api-client' | ||
| import { ProtocolAnalysisSummary } from '@opentrons/shared-data' |
There was a problem hiding this comment.
Suggested change
| import { ProtocolAnalysisSummary } from '@opentrons/shared-data' | |
| import type { ProtocolAnalysisSummary } from '@opentrons/shared-data' |
koji
reviewed
Apr 11, 2024
Comment on lines
1
to
7
| import { | ||
| UseMutationResult, | ||
| UseMutationOptions, | ||
| useMutation, | ||
| UseMutateFunction, | ||
| useQueryClient, | ||
| } from 'react-query' |
There was a problem hiding this comment.
Suggested change
| import { | |
| UseMutationResult, | |
| UseMutationOptions, | |
| useMutation, | |
| UseMutateFunction, | |
| useQueryClient, | |
| } from 'react-query' | |
| import { | |
| useMutation, | |
| useQueryClient, | |
| } from 'react-query' | |
| import type { | |
| UseMutationResult, | |
| UseMutationOptions, | |
| UseMutateFunction, | |
| } from 'react-query' |
koji
reviewed
Apr 11, 2024
| > | ||
|
|
||
| export function useCreateProtocolAnalysisMutation( | ||
| options: UseCreateProtocolAnalysisMutationOptions = {}, |
koji
reviewed
Apr 12, 2024
|
|
||
| import type { ResponsePromise } from '../request' | ||
| import type { HostConfig } from '../types' | ||
| import type { ProtocolAnalysisSummary } from '@opentrons/shared-data' |
koji
reviewed
Apr 12, 2024
| @@ -62,10 +70,10 @@ describe('ProtocolSetupParameters', () => { | |||
| }) | |||
| it('renders the other setting when boolean param is selected', () => { | |||
| render(props) | |||
| screen.getByText('Off') | |||
| expect(screen.getAllByText('On')).toHaveLength(3) | |||
| screen.debug() | |||
There was a problem hiding this comment.
can be removed if there is no specific reason to keep this debug line.
There was a problem hiding this comment.
just an oversight, thanks
koji
reviewed
Apr 12, 2024
Comment on lines
2
to
9
| import type { | ||
| UseMutationResult, | ||
| UseMutationOptions, | ||
| UseMutateFunction, | ||
| } from 'react-query' | ||
| import { createProtocolAnalysis } from '@opentrons/api-client' | ||
| import { useHost } from '../api' | ||
| import type { AxiosError } from 'axios' |
There was a problem hiding this comment.
Suggested change
| import type { | |
| UseMutationResult, | |
| UseMutationOptions, | |
| UseMutateFunction, | |
| } from 'react-query' | |
| import { createProtocolAnalysis } from '@opentrons/api-client' | |
| import { useHost } from '../api' | |
| import type { AxiosError } from 'axios' | |
| import { createProtocolAnalysis } from '@opentrons/api-client' | |
| import { useHost } from '../api' | |
| import type { AxiosError } from 'axios' | |
| import type { | |
| UseMutationResult, | |
| UseMutationOptions, | |
| UseMutateFunction, | |
| } from 'react-query' |
There was a problem hiding this comment.
I will reorder according to this pattern
koji
reviewed
Apr 12, 2024
| response.data | ||
| ) | ||
| ) | ||
| .catch(e => { |
There was a problem hiding this comment.
nit
Suggested change
| .catch(e => { | |
| .catch((e: Error) => { |
koji
reviewed
Apr 12, 2024
| }) | ||
| return response.data | ||
| }) | ||
| .catch(e => { |
There was a problem hiding this comment.
nit
Suggested change
| .catch(e => { | |
| .catch((e: Error) => { |
koji
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-118
Overview
On the ODD, we need to trigger protocol reanalysis via a new
/protocols/{protocolId}/analysesendpoint post request. This analysis should occur when a user sends confirms values on an RTP-containing protocol on the ODD.reference: robot server PR
Test Plan
Changelog
Review requests
protocol authorship devs
Risk assessment
medium